refactor: don't forward -1 as the diagnosticCode #16495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckipp01
added a commit
to ckipp01/metals
that referenced
this pull request
Dec 10, 2022
Since this code means nothing, we should ensure that it's not forwarded to the client. I did upstream a change for this as well in scala/scala3#16495, but I think we should still filter this out now since it is happening.
|
The code doesn't really look like it does what it's said to do. Maybe committed wrong files? |
This change ensures that if the diagnostic code is set to -1 that we instead forward None as the code. This will hopefully help any tooling consuming this to not have to add checks for -1 and filter that code out, since it's a useless code.
Ahhh 😱 Sorry, I just used |
prolativ
approved these changes
Dec 12, 2022
ckipp01
added a commit
to scalameta/metals
that referenced
this pull request
Dec 12, 2022
Since this code means nothing, we should ensure that it's not forwarded to the client. I did upstream a change for this as well in scala/scala3#16495, but I think we should still filter this out now since it is happening.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change ensures that if the diagnostic code is set to -1 that we
instead forward None as the code. This will hopefully help any tooling
consuming this to not have to add checks for -1 and filter that code
out, since it's a useless code.
For example I just hit on this for the first time and saw this:
Ideally we don't this showing, but if the code is forwarded to the client via LSP like it is in the image, the client has no way to know if -1 is a valid code or not.